fix: PIL Image Memory Leaks in Dataset Builders by samiuc · Pull Request #194 · docling-project/docling-eval

samiuc · 2025-12-18T00:56:50Z

During our testing, we found that the memory grows unbounded when processing large datasets, eventually causing OOM errors caused by the PIL Image objects opened during dataset iteration are never closed. Images opened via Image.open() in builders and decoded via Features_Image().decode_example() when loading from parquet accumulate in memory.

So the code changes in this PR add an auto-close PIL Images in as_record_dict() after serialization. Added _close_images()
method to DatasetRecord and DatasetRecordWithPrediction that releases image resources. Also added try/finally blocks in builders (pixparse, funsd, xfund, file_dataset) to close images after local processing.

github-actions · 2025-12-18T00:57:01Z

✅ DCO Check Passed

Thanks @samiuc, all your commits are properly signed off. 🎉

mergify · 2025-12-18T00:57:26Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: a592458 I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: ac622cc I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: 3648bd9 Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: a592458 I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: ac622cc I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: 3648bd9 I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: c05b85e Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: a592458 I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: ac622cc I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: 3648bd9 I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: c05b85e I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: 36044e5 Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

…mory-leaks

cau-git · 2026-01-09T09:36:47Z

@samiuc I would be interested in merging the memory-leaking related fixes, which are definitely needed.

However, the PR also addresses unrelated things that I would like to consider on separate PRs:

Adding parquet mode for OmniDocBench
Numpy 1.x compatibility (why is it needed?)
Some test units that appear not to relate to the fixes

Could you separate the other things out into new PRs please? Thanks.

samiuc · 2026-01-12T07:29:37Z

@cau-git Yes, I do plan to split this into multiple PRs. The main reason everything is currently in a single PR is that internally we build a wheel and test it in our test environment, and it’s alot faster to test multiple fixes together on the same branch.

Once the testing is complete, I’ll open separate PRs. Thanks for taking a look, I’ll follow up shortly with the new PRs.

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: a592458 I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: ac622cc I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: 3648bd9 I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: c05b85e I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: 36044e5 I, samiuc <sami.ullah.chat@gmail.com>, hereby add my Signed-off-by to this commit: b83a1f0 Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

cau-git

@samiuc Thanks for making these changes. Could you please check the feedback below? It is mostly about separation of concerns, and one question on my understanding.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…mory-leaks

… into sami/fix-memory-leaks

Signed-off-by: Christoph Auer <cau@zurich.ibm.com>

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

…oject/docling-eval into sami/fix-memory-leaks

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

mergify · 2026-03-19T19:39:59Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

samiuc · 2026-03-19T19:45:13Z

@cau-git Can you please review this PR when you get some time? Thank you

cau-git

Confirmed working, good to merge! Thanks.

mergify · 2026-03-31T10:43:39Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

samiuc added 2 commits December 17, 2025 16:17

fix: Close PIL Image objects to prevent memory leaks.

a592458

prevent PIL Image memory leaks

ac622cc

samiuc changed the title ~~PIL Image Memory Leaks in Dataset Builders~~ fix: PIL Image Memory Leaks in Dataset Builders Dec 18, 2025

samiuc added 4 commits December 17, 2025 21:54

serialize images to bytes and add EasyOCR test script

3648bd9

style: fix isort import ordering

c05b85e

samiuc requested a review from divekarsc December 29, 2025 18:37

samiuc and others added 6 commits January 5, 2026 13:11

feat: support omnidocbench parquet format

36044e5

fix: format files

7eb9e85

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

fix: tags check

507d55e

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

fix: update pixel evaluator with NumPy 1.x compatible bit counting.

2d8e18e

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

Merge branch 'main' of github.com:DS4SD/docling-eval into sami/fix-me…

3676c73

…mory-leaks

samiuc added 3 commits January 20, 2026 16:58

fix: prevent memory leaks

cf63f3b

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

Merge branch 'main' into sami/fix-memory-leaks

42fe55f

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

reformat and fix type errors

fa86cef

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

divekarsc marked this pull request as ready for review January 23, 2026 00:31

samiuc added 2 commits January 27, 2026 15:50

fix: build error and import tableformer provider optionally

c79c70f

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

remove comment

af28d4e

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

samiuc requested a review from cau-git January 28, 2026 00:12

samiuc added 4 commits January 28, 2026 17:30

fix: reset streams and adding image refs

b83a1f0

fix TableStructureModel import path

0d22227

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

cau-git requested changes Feb 10, 2026

View reviewed changes

cau-git requested a review from Copilot February 10, 2026 10:27

Copilot started reviewing on behalf of cau-git February 10, 2026 10:29 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

cau-git and others added 6 commits February 11, 2026 10:40

Merge branch 'main' of github.com:DS4SD/docling-eval into sami/fix-me…

0a3ac0c

…mory-leaks

Merge branch 'sami/fix-memory-leaks' of github.com:DS4SD/docling-eval…

e2acef0

… into sami/fix-memory-leaks

Update dependencies and uv.lock

c9070c8

Signed-off-by: Christoph Auer <cau@zurich.ibm.com>

address review comments

66c62af

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

Merge branch 'sami/fix-memory-leaks' of https://github.com/docling-pr…

1eb3e10

…oject/docling-eval into sami/fix-memory-leaks

Merge branch 'main' into sami/fix-memory-leaks

f2bbf6e

Signed-off-by: samiuc <sami.ullah.chat@gmail.com>

samiuc commented Mar 19, 2026

View reviewed changes

Comment thread docling_eval/dataset_builders/omnidocbench_builder.py

cau-git self-requested a review March 31, 2026 10:42

cau-git approved these changes Mar 31, 2026

View reviewed changes

cau-git merged commit 55fd3eb into main Mar 31, 2026
10 checks passed

cau-git deleted the sami/fix-memory-leaks branch March 31, 2026 10:44

Conversation

samiuc commented Dec 18, 2025

Uh oh!

github-actions Bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Protections

🟢 Enforce conventional commit

Uh oh!

cau-git commented Jan 9, 2026

Uh oh!

samiuc commented Jan 12, 2026

Uh oh!

cau-git left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Mar 19, 2026

Merge Protections

🟢 Enforce conventional commit

Uh oh!

Uh oh!

samiuc commented Mar 19, 2026

Uh oh!

cau-git left a comment

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Mar 31, 2026

Merge Protections

🟢 Enforce conventional commit

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Dec 18, 2025 •

edited

Loading

mergify Bot commented Dec 18, 2025 •

edited

Loading